Nico Huber has posted comments on this change. ( https://review.coreboot.org/28909 )
Change subject: nb/intel/{gm45,i945,pineview}: Use macro instead of GGC address
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28909/1/src/northbridge/intel/gm45/iommu.c
File src/northbridge/intel/gm45/iommu.c:
https://review.coreboot.org/#/c/28909/1/src/northbridge/intel/gm45/iommu.c@4...
PS1, Line 49: u16 gtt
u16 ?
You can use u16, but it might be slower (not sure how Intel
implements it).
--
To view, visit
https://review.coreboot.org/28909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I233e835180fd445961b6deb74ea7afc2821c236e
Gerrit-Change-Number: 28909
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Oct 2018 13:05:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes