Change in coreboot[master]: src/soc/intel/xeon_sp: Override cache error correction type and cache...

[Morgan Jang (Code Review)]

Morgan Jang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override cache error correction type and cache sram type in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Override cache error correction type and cache sram type in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type and
cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/1

diff --git a/src/soc/intel/xeon_sp/Makefile.inc b/src/soc/intel/xeon_sp/Makefile.inc
index 3bbf6b7..40dafb5 100644
--- a/src/soc/intel/xeon_sp/Makefile.inc
+++ b/src/soc/intel/xeon_sp/Makefile.inc
@@ -7,7 +7,7 @@

bootblock-y += bootblock.c spi.c lpc.c gpio.c pch.c
 romstage-y += romstage.c reset.c util.c spi.c gpio.c pmutil.c
-ramstage-y += uncore.c reset.c util.c lpc.c spi.c gpio.c
+ramstage-y += uncore.c reset.c util.c lpc.c spi.c gpio.c ramstage.c
 ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC) += pmc.c
 postcar-y += spi.c

diff --git a/src/soc/intel/xeon_sp/ramstage.c b/src/soc/intel/xeon_sp/ramstage.c
new file mode 100644
index 0000000..d4334da
--- /dev/null
+++ b/src/soc/intel/xeon_sp/ramstage.c
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <smbios.h>
+
+unsigned int smbios_cache_error_correction_type(void)
+{
+	return SMBIOS_CACHE_ERROR_CORRECTION_SINGLE_BIT;
+}
+
+unsigned int smbios_cache_sram_type(void)
+{
+	return SMBIOS_CACHE_SRAM_TYPE_SYNCHRONOUS;
+}

[Morgan Jang (Code Review)]

Hello Patrick Georgi, Martin Roth, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#2).

Change subject: src/soc/intel/xeon_sp: Override cache error correction type and cache sram type in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Override cache error correction type and cache sram type in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/2

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#3).

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/3

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46119/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46119/3//COMMIT_MSG@8 
PS3, Line 8: 
This looks modelled strangely. If it’s configuration, why doesn’t it go into Kconfig or devicetree?

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jonathan Zhang, Johnny Lin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#4).

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Kconfig
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
3 files changed, 28 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/4

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jonathan Zhang, Johnny Lin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#5).

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Kconfig
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
3 files changed, 29 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/5

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46119/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46119/3//COMMIT_MSG@8 
PS3, Line 8:
> This looks modelled strangely. […]

Done

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46119/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46119/5//COMMIT_MSG@7 
PS5, Line 7: Override the
Fill in

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
File src/soc/intel/xeon_sp/Kconfig:

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
PS5, Line 105: 	default 5
The problem with using Kconfig for this is that you cannot use enum values.

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
File src/soc/intel/xeon_sp/Kconfig:

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
PS5, Line 105: 	default 5
> The problem with using Kconfig for this is that you cannot use enum values.

Maybe move these two parameter to device tree?

Change in coreboot[master]: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Override the cache information in SMBIOS type 7
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
File src/soc/intel/xeon_sp/Kconfig:

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
PS5, Line 105: 	default 5
> Maybe move these two parameter to device tree?

No, let the CPU/SoC code fill them in by overriding the weak functions instead.

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jonathan Zhang, Johnny Lin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#6).

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 27 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/6

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jonathan Zhang, Johnny Lin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#7).

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 27 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/7

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46119/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46119/5//COMMIT_MSG@7 
PS5, Line 7: Override the
> Fill in

Done

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
File src/soc/intel/xeon_sp/Kconfig:

https://review.coreboot.org/c/coreboot/+/46119/5/src/soc/intel/xeon_sp/Kconf... 
PS5, Line 105: 	default 5
> No, let the CPU/SoC code fill them in by overriding the weak functions instead.

Done

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Morgan Jang (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jonathan Zhang, Johnny Lin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46119

to look at the new patch set (#8).

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 27 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/46119/8

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

Patch Set 9: Code-Review+2

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

Patch Set 9: Code-Review+2

Change in coreboot[master]: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46119 )

Change subject: src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7
......................................................................

src/soc/intel/xeon_sp: Fill in the cache information in SMBIOS type 7

TEST=Execute "dmidecode -t 7" to check if cache error correction type
and cache sram type is correct for each cache level

Change-Id: Ibe7c6ad03a83a6a3b2c7dfcfafaa619e690a418d
Signed-off-by: Morgan Jang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46119
Tested-by: build bot (Jenkins) 
Reviewed-by: Jonathan Zhang 
Reviewed-by: Angel Pons 
---
M src/soc/intel/xeon_sp/Makefile.inc
A src/soc/intel/xeon_sp/ramstage.c
2 files changed, 27 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Jonathan Zhang: Looks good to me, approved

diff --git a/src/soc/intel/xeon_sp/Makefile.inc b/src/soc/intel/xeon_sp/Makefile.inc
index 8a26c14..ffc55b6 100644
--- a/src/soc/intel/xeon_sp/Makefile.inc
+++ b/src/soc/intel/xeon_sp/Makefile.inc
@@ -7,7 +7,7 @@

bootblock-y += bootblock.c spi.c lpc.c gpio.c pch.c
 romstage-y += romstage.c reset.c util.c spi.c gpio.c pmutil.c
-ramstage-y += uncore.c reset.c util.c lpc.c spi.c gpio.c nb_acpi.c
+ramstage-y += uncore.c reset.c util.c lpc.c spi.c gpio.c nb_acpi.c ramstage.c
 ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC) += pmc.c
 postcar-y += spi.c

diff --git a/src/soc/intel/xeon_sp/ramstage.c b/src/soc/intel/xeon_sp/ramstage.c
new file mode 100644
index 0000000..68d5d46
--- /dev/null
+++ b/src/soc/intel/xeon_sp/ramstage.c
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <smbios.h>
+
+unsigned int smbios_cache_error_correction_type(u8 level)
+{
+	return SMBIOS_CACHE_ERROR_CORRECTION_SINGLE_BIT;
+}
+
+unsigned int smbios_cache_sram_type(void)
+{
+	return SMBIOS_CACHE_SRAM_TYPE_SYNCHRONOUS;
+}
+
+unsigned int smbios_cache_conf_operation_mode(u8 level)
+{
+	switch (level) {
+	case 1:
+		return SMBIOS_CACHE_OP_MODE_WRITE_BACK;
+	case 2:
+	case 3:
+		return SMBIOS_CACHE_OP_MODE_VARIES_WITH_MEMORY_ADDRESS;
+	default:
+		return SMBIOS_CACHE_OP_MODE_UNKNOWN;
+	}
+}