Change in coreboot[master]: mb/prodrive/hermes: Drop Vref configuration for older boards
Attention is currently required from: Justin van Son, Christian Walter. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/prodrive/hermes/variants/r04/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51919/comment/fc3c4b2d_db85724c PS1, Line 42: return AZALIA_PIN_DESC(
The driver won't detect a valid pin configuration when AZALIA_PIN_DESC is used. […]
Should this use a separate association? Maybe 0x4 instead of 0xf? Other verb tables set the type to ANALOG instead of UNKNOWN. No_presence_detect should be true.
https://review.coreboot.org/c/coreboot/+/51919/comment/ab8684e5_630b9773 PS1, Line 69: 0x018707e1, /* port B VREF 50% of LDO-OUT */
You don't need any of the 707 verbs, as they will get reset by realtek driver anyway
will drop them here.
-
Patrick Rudolph (Code Review)