Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38086 )
Change subject: mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size ......................................................................
mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size
It probably comes from older autoport.
Change-Id: I9950fd10e45f5016611a5d5b6a9e41c2b0f25a5f Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/hp/folio_9470m/devicetree.cb M src/mainboard/hp/revolve_810_g1/devicetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/38086/1
diff --git a/src/mainboard/hp/folio_9470m/devicetree.cb b/src/mainboard/hp/folio_9470m/devicetree.cb index 13a12b6..e04ab67 100644 --- a/src/mainboard/hp/folio_9470m/devicetree.cb +++ b/src/mainboard/hp/folio_9470m/devicetree.cb @@ -14,8 +14,8 @@ # GNU General Public License for more details. #
-chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did - register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" +chip northbridge/intel/sandybridge + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" register "gfx.link_frequency_270_mhz" = "1" register "gfx.ndid" = "3" register "gfx.use_spread_spectrum_clock" = "1" diff --git a/src/mainboard/hp/revolve_810_g1/devicetree.cb b/src/mainboard/hp/revolve_810_g1/devicetree.cb index 0de3930..048120a 100644 --- a/src/mainboard/hp/revolve_810_g1/devicetree.cb +++ b/src/mainboard/hp/revolve_810_g1/devicetree.cb @@ -14,8 +14,8 @@ # GNU General Public License for more details. #
-chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did - register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" +chip northbridge/intel/sandybridge + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" register "gfx.link_frequency_270_mhz" = "1" register "gfx.ndid" = "3" register "gfx.use_spread_spectrum_clock" = "1"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38086 )
Change subject: mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size ......................................................................
Patch Set 1: Code-Review-1
Why drop the FIXMEs? Commit message doesn't say that you checked the numbers?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38086 )
Change subject: mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size ......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
Why drop the FIXMEs? Commit message doesn't say that you checked the numbers?
I would say I have addressed them. What's more: I've checked the numbers just now. Since I didn't change the autoport default values in the first patchset of CB:26419 (my Asus P8H61-M PRO port), I've grabbed them:
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }"
Compared to these boards' values, it's a match! So I'll update the commit message accordingly.
Hello Bill XIE, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38086
to look at the new patch set (#2).
Change subject: mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size ......................................................................
mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size
These values are the same that were hardcoded in autoport before. As done in commit 08caa79 (util/autoport: Trim gfx.did to size), ensure that the hardcoded values make at least some sense.
Change-Id: I9950fd10e45f5016611a5d5b6a9e41c2b0f25a5f Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/hp/folio_9470m/devicetree.cb M src/mainboard/hp/revolve_810_g1/devicetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/38086/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38086 )
Change subject: mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38086 )
Change subject: mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size ......................................................................
mb/hp/{folio_9470m,revolve_810_g1}: Trim gfx.did to size
These values are the same that were hardcoded in autoport before. As done in commit 08caa79 (util/autoport: Trim gfx.did to size), ensure that the hardcoded values make at least some sense.
Change-Id: I9950fd10e45f5016611a5d5b6a9e41c2b0f25a5f Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38086 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/hp/folio_9470m/devicetree.cb M src/mainboard/hp/revolve_810_g1/devicetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/hp/folio_9470m/devicetree.cb b/src/mainboard/hp/folio_9470m/devicetree.cb index 13a12b6..e04ab67 100644 --- a/src/mainboard/hp/folio_9470m/devicetree.cb +++ b/src/mainboard/hp/folio_9470m/devicetree.cb @@ -14,8 +14,8 @@ # GNU General Public License for more details. #
-chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did - register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" +chip northbridge/intel/sandybridge + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" register "gfx.link_frequency_270_mhz" = "1" register "gfx.ndid" = "3" register "gfx.use_spread_spectrum_clock" = "1" diff --git a/src/mainboard/hp/revolve_810_g1/devicetree.cb b/src/mainboard/hp/revolve_810_g1/devicetree.cb index 0de3930..048120a 100644 --- a/src/mainboard/hp/revolve_810_g1/devicetree.cb +++ b/src/mainboard/hp/revolve_810_g1/devicetree.cb @@ -14,8 +14,8 @@ # GNU General Public License for more details. #
-chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did - register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" +chip northbridge/intel/sandybridge + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" register "gfx.link_frequency_270_mhz" = "1" register "gfx.ndid" = "3" register "gfx.use_spread_spectrum_clock" = "1"
-
Angel Pons (Code Review) -
Nico Huber (Code Review)