Patch Set 1: Code-Review-1

Why drop the FIXMEs? Commit message doesn't say that you checked the numbers?

I would say I have addressed them. What's more: I've checked the numbers just now. Since I didn't change the autoport default values in the first patchset of CB:26419 (my Asus P8H61-M PRO port), I've grabbed them:

 register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }"

Compared to these boards' values, it's a match! So I'll update the commit message accordingly.

View Change

To view, visit change 38086. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9950fd10e45f5016611a5d5b6a9e41c2b0f25a5f
Gerrit-Change-Number: 38086
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 04 Jan 2020 18:13:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment