Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58925 )
Change subject: soc/intel: move SGX ACPI code to block/acpi
......................................................................
Patch Set 2:
(1 comment)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/58925/comment/8d768a9f_8235f49a
PS2, Line 1239: void sgx_fill_ssdt(void);
Why is this function declaration in common code, and not somewhere in soc/intel?
ugh, that wasn't intended... should have been in `soc/intel/common/block/include/intelblocks/acpi.h`
Why move it? intelblocks/sgx.h looks like the right place?
bc it's ACPI; other declarations are there, too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I089d0ee97c37df2be060b5996183201bfa9b49ca
Gerrit-Change-Number: 58925
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Nov 2021 16:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment