Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39995 )
Change subject: mb/siemens/chili: Add Chili variant ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... File src/mainboard/siemens/chili/variants/chili/romstage.c:
https://review.coreboot.org/c/coreboot/+/39995/13/src/mainboard/siemens/chil... PS13, Line 6: pc80/mc146818rtc.h
maybe not used
Done
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/variants/chili/devicetree.cb:
PS1:
Maybe use overridetrees? Or are the boards significantly different?
I will switch to overridetree in another patch. I think this patch should only add the variant and not touching the base variants devicetree.
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/variants/chili/gpio.c:
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... PS1, Line 127:
there's two spaces here
Done
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/variants/chili/smbios.c:
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... PS1, Line 26: Boxer26
More boxer26
Done
-
Felix Singer (Code Review)