Attention is currently required from: Simon Glass.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59604 )
Change subject: emulation/qemu-i440fx: Use a 1MB ROM by default with U-Boot
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
All other emulation boards besides Q35 use 4M. A big use case for emulation boards is to test payloads and 256K is too small for that. I'd just increase it regardless of the payload.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1a8c1109e3ece5fec56255173a2d19d4a130bcb
Gerrit-Change-Number: 59604
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Comment-Date: Wed, 24 Nov 2021 20:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment