Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46272 )
Change subject: soc/intel/{common,skl}: move AES-NI locking to common code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46272/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/46272/2/src/soc/intel/common/block/...
PS2, Line 386: disabling
What about unintended enabling? the function doesn't seem to check
if it's enabled.
Also, this lock what can be locked policy is Intel's idea and coreboot
tends to disagree. See `config SET_IA32_FC_LOCK_BIT` for instance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81ad5c0d4797b139435c57d3af0a95db94a5c15e
Gerrit-Change-Number: 46272
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 11 Oct 2020 12:43:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment