Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Karthik Ramasubramanian, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email )
Change subject: soc/intel/cmn/pmc: Add support for early power off
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
LGTM after comments
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/86336/comment/4776e25a_1a860f1e?usp... :
PS6, Line 314: #if CONFIG(HAVE_EARLY_POWEROFF_SUPPORT)
This is unnecessary because the function will never get called when the Kconfig is off anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86336?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b
Gerrit-Change-Number: 86336
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:11:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes