Attention is currently required from: Felix Singer, Filip Lewiński, Martin L Roth, Michał Kopeć.
Krystian Hebel has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82041?usp=email )
Change subject: payloads/external/iPXE: introduce support for named configurations
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
Patchset:
PS7:
Doesn't build without specifying named config:
```
Switched to a new branch 'coreboot'
Checking named config directory: named-configs/
Applying named configuration:
cp: cannot stat 'named-configs//*': No such file or directory
make[1]: *** [Makefile:41: apply_named_config] Error 1
make: *** [payloads/external/Makefile.mk:372: payloads/external/iPXE/ipxe/ipxe.rom] Error 2
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82041?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf7c2d9e4407035bfdf0115f4628f23b38272656
Gerrit-Change-Number: 82041
Gerrit-PatchSet: 7
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Thu, 30 Jan 2025 12:20:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Krystian Hebel (Code Review)