David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Update DPTF parameters
Update DPTF parameters for terrador
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46487/1
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index 1ccdb87..56b4fbd 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -17,6 +17,50 @@ register "SaGv" = "SaGv_Disabled"
device domain 0 on + device pci 04.0 on + # Default DPTF Policy for all Volteer boards if not overridden + chip drivers/intel/dptf + ## Passive Policy + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, CPU, 89, 1000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), + [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), + [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" + + ## Critical Policy + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(CPU, 100, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 75, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 75, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 75, SHUTDOWN), + [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 75, SHUTDOWN)}" + + ## Power Limits Control + # 3-9W PL1 in 200mW increments, avg over 28-32s interval + # PL2 ranges from 9 to 40W, avg over 28-32s interval + register "controls.power_limits" = "{ + .pl1 = {.min_power = 3000, + .max_power = 9000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 200,}, + .pl2 = {.min_power = 9000, + .max_power = 40000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 1000,}}" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 1700 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 }}" + + device generic 0 on end + end + end # DPTF 0x9A03 device ref i2c0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46487
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Update DPTF parameters
Update DPTF parameters for terrador and todor
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 88 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46487/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46487
to look at the new patch set (#3).
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Update DPTF parameters
Update DPTF parameters for terrador and todor
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 86 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46487/3
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46487
to look at the new patch set (#4).
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Update DPTF parameters
Update DPTF parameters for terrador and todor
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 86 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46487/4
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 24: [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" : nit: it's a little easier to read if all of the columns are lined up with tabs
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 62: # DPTF 0x9A03 nit: with the alias names (`ref dptf`, I don't think these comments are as helpful)
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/todor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 24: [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" nit: it's a little easier to read if all of the columns are lined up with tabs
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 62: # DPTF 0x9A03 nit: same
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46487
to look at the new patch set (#5).
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Update DPTF parameters
Update DPTF parameters for terrador and todor
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 86 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46487/5
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 24: [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" :
nit: it's a little easier to read if all of the columns are lined up with tabs
Done
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 62: # DPTF 0x9A03
nit: with the alias names (`ref dptf`, I don't think these comments are as helpful)
Done
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/todor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 24: [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), : [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), : [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}"
nit: it's a little easier to read if all of the columns are lined up with tabs
Done
https://review.coreboot.org/c/coreboot/+/46487/4/src/mainboard/google/voltee... PS4, Line 62: # DPTF 0x9A03
nit: same
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
Patch Set 5: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Update DPTF parameters ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46487/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46487/5//COMMIT_MSG@7 PS5, Line 7: mb/google/volteer/var/terrador: Update DPTF parameters It looks like they have not been configured before. So, maybe:
Configure board specific/optimized DPTF parameters
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46487
to look at the new patch set (#6).
Change subject: mb/google/volteer/var/terrador: Configure board specific DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Configure board specific DPTF parameters
Configure board specific DPTF parameters for terrador and todor
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 86 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/46487/6
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Configure board specific DPTF parameters ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46487/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46487/5//COMMIT_MSG@7 PS5, Line 7: mb/google/volteer/var/terrador: Update DPTF parameters
It looks like they have not been configured before. So, maybe: […]
Done
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46487 )
Change subject: mb/google/volteer/var/terrador: Configure board specific DPTF parameters ......................................................................
mb/google/volteer/var/terrador: Configure board specific DPTF parameters
Configure board specific DPTF parameters for terrador and todor
BUG=b:171019363,b:170699797 BRANCH=volteer TEST=build and verify by thermal team
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I19935ca98ec7a078869e73d65ea471df70f37121 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46487 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 86 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index 1ccdb87..001d5f6 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -17,6 +17,49 @@ register "SaGv" = "SaGv_Disabled"
device domain 0 on + device ref dptf on + chip drivers/intel/dptf + ## Passive Policy + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), + [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), + [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" + + ## Critical Policy + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(CPU, 100, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 75, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 75, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 75, SHUTDOWN), + [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 75, SHUTDOWN)}" + + ## Power Limits Control + # 3-9W PL1 in 200mW increments, avg over 28-32s interval + # PL2 ranges from 9 to 40W, avg over 28-32s interval + register "controls.power_limits" = "{ + .pl1 = {.min_power = 3000, + .max_power = 9000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 200,}, + .pl2 = {.min_power = 9000, + .max_power = 40000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 1000,}}" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 1700 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 }}" + + device generic 0 on end + end + end device ref i2c0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index 1ccdb87..001d5f6 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -17,6 +17,49 @@ register "SaGv" = "SaGv_Disabled"
device domain 0 on + device ref dptf on + chip drivers/intel/dptf + ## Passive Policy + register "policies.passive" = "{ + [0] = DPTF_PASSIVE(CPU, CPU, 85, 1000), + [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), + [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), + [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), + [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}" + + ## Critical Policy + register "policies.critical" = "{ + [0] = DPTF_CRITICAL(CPU, 100, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 75, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 75, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 75, SHUTDOWN), + [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 75, SHUTDOWN)}" + + ## Power Limits Control + # 3-9W PL1 in 200mW increments, avg over 28-32s interval + # PL2 ranges from 9 to 40W, avg over 28-32s interval + register "controls.power_limits" = "{ + .pl1 = {.min_power = 3000, + .max_power = 9000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 200,}, + .pl2 = {.min_power = 9000, + .max_power = 40000, + .time_window_min = 28 * MSECS_PER_SEC, + .time_window_max = 32 * MSECS_PER_SEC, + .granularity = 1000,}}" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 1700 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 }}" + + device generic 0 on end + end + end device ref i2c0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
David Wu (Code Review) -
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)