Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Julius Werner, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68748 )
Change subject: security/tpm: add TPM log format as per 2.0 spec ......................................................................
Patch Set 6:
(4 comments)
File src/security/tpm/tpm2_log_serialized.h:
https://review.coreboot.org/c/coreboot/+/68748/comment/dad327b5_e9a3f911 PS5, Line 38: struct tpm_2_log_entry {
Why aren't these structures in commonlib when the spec_id ones are? Wouldn't e.g. […]
At the moment `cbmem` parses log in its generic form (arbitrary number of hashes and variable-length fields) and doesn't need to know these implementation-specific declarations.
File src/security/tpm/tspi/log-tpm2.c:
https://review.coreboot.org/c/coreboot/+/68748/comment/9e116798_ef56368a PS5, Line 77: MAX_TPM_LOG_ENTRIES
Is it intentional that these two fields don't get forced to little-endian while the others do? Is gu […]
Done
https://review.coreboot.org/c/coreboot/+/68748/comment/363f793b_2dba9a71 PS5, Line 158: strncpy((char *)tce->data, name, sizeof(tce->data) - 1);
Same termination issue here.
Done
https://review.coreboot.org/c/coreboot/+/68748/comment/ce12ee52_0d5757e7 PS5, Line 176: tce->pcr
le32toh?
Yes, thanks. Same in TPM1 log format.
-
Sergii Dmytruk (Code Review)