Martin Roth has posted comments on this change. ( https://review.coreboot.org/22635 )
Change subject: amd/stoneyridge/include/soc/northbridge.h: Cleanup ......................................................................
Patch Set 1: Code-Review-1
(4 comments)
I'd rather that none of these changes were made.
https://review.coreboot.org/#/c/22635/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@9 PS1, Line 9: There are instances where the pound "#" is separated from the word "define", : it should be all together "#define". Why? This is a common convention throughout the codebase to show that this #define is a part of the previous register.
This extra space helps visually to separate the register number from the register components.
https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@12 PS1, Line 12: There are instances where bits are being declared as (1 << x), should be : replaced by macro BIT(x). Again, the (1 << x) is very common throughout the coreboot codebase. What's the reason to change it in this file? If it were mixed, I could see it all getting converted one way or the other, but why change it here?
https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@15 PS1, Line 15: 62239898 62239898 - Kahlee: coreboot - stoneyridge - include headers for filetypes used.
What does this change have to do with this bug?
https://review.coreboot.org/#/c/22635/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/northbridge.h:
https://review.coreboot.org/#/c/22635/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 59: BIT(0) No longer aligned after removing the space.
-
Martin Roth (Code Review)