Martin Roth posted comments on this change.
Patch set 1:Code-Review -1
I'd rather that none of these changes were made.
(4 comments)
There are instances where the pound "#" is separated from the word "define",
it should be all together "#define".
Why? This is a common convention throughout the codebase to show that this #define is a part of the previous register.
This extra space helps visually to separate the register number from the register components.
There are instances where bits are being declared as (1 << x), should be
replaced by macro BIT(x).
Again, the (1 << x) is very common throughout the coreboot codebase. What's the reason to change it in this file? If it were mixed, I could see it all getting converted one way or the other, but why change it here?
Patch Set #1, Line 15: 62239898
62239898 - Kahlee: coreboot - stoneyridge - include headers for filetypes used.
What does this change have to do with this bug?
File src/soc/amd/stoneyridge/include/soc/northbridge.h:
Patch Set #1, Line 59: BIT(0)
No longer aligned after removing the space.
To view, visit change 22635. To unsubscribe, visit settings.