Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mb/acer: Add Acer Aspire ES1-572 ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38978/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38978/7//COMMIT_MSG@37 PS7, Line 37: - Touchpad. Hangs off either EC or some I2C controller and needs ACPI. it's connected to EC via PS2 and to SoC via I2C. ACPI is done by the cb i2c driver, when added to the devicetree. fortunately, no need to manually hack around. have a look at CB:43623 for a working example
https://review.coreboot.org/c/coreboot/+/38978/7/src/mainboard/acer/es1-572/... File src/mainboard/acer/es1-572/gpio.c:
https://review.coreboot.org/c/coreboot/+/38978/7/src/mainboard/acer/es1-572/... PS7, Line 7: #define PAD_CFG_NF_BUF_TRIG(a, b, c, d, e, f) PAD_CFG_NF(a, b, c, d) just drop e and f below and used PAD_CFG_NF. they are not needed to be set for native functions, which is why the macro was removed
https://review.coreboot.org/c/coreboot/+/38978/7/src/mainboard/acer/es1-572/... PS7, Line 144: _PAD_CFG_STRUCT(GPP_B3, : PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | : PAD_CFG0_TRIG_LEVEL | PAD_CFG0_RX_POL_YES | : PAD_BUF(TX_DISABLE), : PAD_PULL(NONE)), : PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST) for touchpad interrupt
-
Michael Niewöhner (Code Review)