Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: HACK trogdor: SoC makefile BLOB support HACK ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/Ma... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/Ma... PS15, Line 102: DCB_FILE := $(SC7180_BLOB)/600E_0100_1_1_dcb.bin
Julius, […]
Sorry, I don't understand what you mean here? QcLib doesn't ever get to see this filename, all it gets to see is the "dcb_settings" QcLib interface table entry. In fact, not even coreboot gets to see this filename (in CBFS this is just called "fallback/dcb"). The only place where this filename currently exists is in the build file -- how the file is called in 3rdparty/blobs and the name this Makefile uses to find that. That's all I want you to change.
I don't care how Qualcomm calls this internally, or even how it is called in the chipcode drops. I can rename it when I download a new version from chipcode. I just think that locally inside coreboot it doesn't need to be such a complicated name, if coreboot calls it "dcb.bin" rather than "600E_0100_1_1_dcb.bin" that makes it obvious that I need to rename something (whereas the difference between "600E_0100_1_1_dcb.bin" and 600E_0100_1_dcb.bin" was easy to overlook).