Attention is currently required from: Kapil Porwal, Nick Vaccaro, Varshit Pandya.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81631?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Sort Kconfig option alphabetically
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81631/comment/6b2144da_9c51cd0e :
PS3, Line 574: config DRIVER_TPM_I2C_BUS
How about combining multiple mainboards with conditions here?
Like ..
```
default 0x0 if BOARD_GOOGLE_ANRAGGAR || ..
default 0x1 if BOARD_GOOGLE_AURASH || ..
...
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81631?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I878c14058e1edc0f64e37c2fc16b8dcf75b90192
Gerrit-Change-Number: 81631
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 05 Apr 2024 04:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment