Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Mathew King, Paul Menzel, Julius Werner.
Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57864 )
Change subject: guybrush: add RO_GSCVD area to FMAP
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/guybrush/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/57864/comment/10e55afd_233e5373
PS1, Line 29: RO_GSCVD 8K
I thing RO_GSCVD should be part of the RO section, and should be updated only if WP is disabled an […]
ah, I am confusing RO_SECTION and WP_RO, moved to WP_RO, put it after VPD which is not supposed to be changing with firmware updates.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa24d5a6271a8bcbf737d4580ec85b9cfdd9af01
Gerrit-Change-Number: 57864
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 23 Nov 2021 21:34:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Vadim Bendebury
vbendeb@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment