Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86864?usp=email )
Change subject: soc/amd/*/psp_verstage: Remove duplicate verstage-generic-ccopts
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
not directly related to this change: is there a difference between '$(src)' and 'src'? looks a bit odd to me to have a mix of those two in there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86864?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic64f5187e50b903af5461bfa4d57bb4951d3b501
Gerrit-Change-Number: 86864
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: Andy Ebrahiem
ahmet.ebrahiem@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:10:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes