Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull libgfxinit in early romstage ......................................................................
Patch Set 3:
(5 comments)
File src/arch/x86/car.ld:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164210): https://review.coreboot.org/c/coreboot/+/69757/comment/f075248a_c232be90 PS3, Line 72: * un-initialized variables which are initialized at runtime. Therefor, 'Therefor' may be misspelled - perhaps 'Therefore'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164210): https://review.coreboot.org/c/coreboot/+/69757/comment/d2d2b937_39726019 PS3, Line 73: * they can be be placed in the .bss section.*/ Possible repeated word: 'be'
File src/soc/intel/common/block/graphics/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164210): https://review.coreboot.org/c/coreboot/+/69757/comment/a889e1dc_ff771e07 PS3, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164210): https://review.coreboot.org/c/coreboot/+/69757/comment/68737290_ed223e75 PS3, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164210): https://review.coreboot.org/c/coreboot/+/69757/comment/579ac195_0c903e80 PS3, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)