Attention is currently required from: Martin L Roth, Fred Reitberger, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74150 )
Change subject: Makefile.inc: introduce all_x86 target
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74150/comment/6cadefd3_830c99a8
PS2, Line 11: all
single-quote for clarity
Done
https://review.coreboot.org/c/coreboot/+/74150/comment/d05bb3f0_8b8acf7c
PS2, Line 14: omstage
oxford comma
i think that the oxford comma looks quite bad, but i'm not the native english speaker here, so i'll just add it
https://review.coreboot.org/c/coreboot/+/74150/comment/606b6bb9_a47a6e95
PS2, Line 14: verstage_x88
_x86
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0184182b931185990094d0874b49c0b5cb9f7e
Gerrit-Change-Number: 74150
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 17:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment