Attention is currently required from: YH Lin, Joey Peng, Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60532 )
Change subject: mb/google/brya/var/taniks:Change probe for audio 4 channel speaker
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60532/comment/c17bc6a9_47a4a1e0
PS2, Line 7: :C
nit: space after `:`
https://review.coreboot.org/c/coreboot/+/60532/comment/86ef4a01_62fa595e
PS2, Line 9: .C
nit: space after `.`
Patchset:
PS2:
+Nick, https://crrev.com/c/3358671 will need a Cq-Depend on this one when it lands in the chromium tree
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2986bd212cef47f70dfeedc642a8db3314c947f6
Gerrit-Change-Number: 60532
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 21:48:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment