Attention is currently required from: Kevin Chiu, Felix Held.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )
Change subject: soc/amd/picasso: add UPD for RV2 USB3 phy setting adjust
......................................................................
Patch Set 13:
(3 comments)
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/50240/comment/cf90e072_233ad5cb
PS7, Line 75: #define USB3_PORT_COUNT 4
Yes, check with the design guide, the USB3 phy setting should only apply to controller 0. […]
Done
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50240/comment/63312e1e_0a0ac299
PS4, Line 131: memcpy(&scfg->usb_3_port0_phy_tune, &cfg->usb3_phy_tune_params[0],
: sizeof(scfg->usb_3_port0_phy_tune[0]));
yes, The default value was given in both trembyle and dalboz devtree. […]
Done
File src/vendorcode/amd/fsp/picasso/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/50240/comment/cb75af72_c23f2363
PS7, Line 61: /** Offset 0x0143**/ uint8_t usb_3_port3_phy_tune[2];
those port should belong to controller 0 and in our Picasso-PI or Pollock-PI. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d5f69e840952cc5171af1ce8597628d1bede5cb
Gerrit-Change-Number: 50240
Gerrit-PatchSet: 13
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Feb 2021 07:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: chris wang
Chris.Wang@amd.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment