Attention is currently required from: Nico Huber, Tim Wawrzynczak, Paul Menzel, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52491 )
Change subject: soc/intel/cannonlake: Merge soc_memory_init_params() into its caller
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52491/comment/1a7280b2_b12891b1
PS7, Line 13:
Have you tested if this affects the binary?
Just tested. Binary remains the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52491
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3b6395ea5d5cb714a412c856d66d4a9bcbd9c12
Gerrit-Change-Number: 52491
Gerrit-PatchSet: 10
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 08 May 2021 01:38:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment