Change in coreboot[master]: mb/lippert/frontrunner-af: frontrunner-af: Add blank line in code
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46716 )
Change subject: mb/lippert/frontrunner-af: frontrunner-af: Add blank line in code ......................................................................
mb/lippert/frontrunner-af: frontrunner-af: Add blank line in code
Adding the blank line, reduces the differences with the variant toucan-af.
Change-Id: I58bfc99109a2df2eab54a562dc13e7bd946890d9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46716/1
diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c index 71d0f41..e32e125 100644 --- a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c @@ -79,6 +79,7 @@ iomux_write8(190, 1); iomux_write8(191, 1); iomux_write8(192, 1); + /* just in case anyone cares */ if (!fch_gpio_state(197)) printk(BIOS_INFO, "BIOS_DEFAULTS jumper is present.\n");
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46716
to look at the new patch set (#2).
Change subject: mb/lippert/frontrunner-af: frontrunner-af: Add blank line in code ......................................................................
mb/lippert/frontrunner-af: frontrunner-af: Add blank line in code
Adding the blank line reduces the differences with the variant toucan-af.
Change-Id: I58bfc99109a2df2eab54a562dc13e7bd946890d9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46716/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46716 )
Change subject: mb/lippert/frontrunner-af: frontrunner-af: Add blank line in code ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46716/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46716/1//COMMIT_MSG@7 PS1, Line 7: frontrunner-af: spurious?
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46716
to look at the new patch set (#3).
Change subject: mb/lippert/frontrunner-af: Add blank line in code ......................................................................
mb/lippert/frontrunner-af: Add blank line in code
Adding the blank line reduces the differences with the variant toucan-af.
Change-Id: I58bfc99109a2df2eab54a562dc13e7bd946890d9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/46716/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46716 )
Change subject: mb/lippert/frontrunner-af: Add blank line in code ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46716/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46716/1//COMMIT_MSG@7 PS1, Line 7: frontrunner-af:
spurious?
Thanks!
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46716 )
Change subject: mb/lippert/frontrunner-af: Add blank line in code ......................................................................
mb/lippert/frontrunner-af: Add blank line in code
Adding the blank line reduces the differences with the variant toucan-af.
Change-Id: I58bfc99109a2df2eab54a562dc13e7bd946890d9 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/46716 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c index 71d0f41..e32e125 100644 --- a/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/variants/frontrunner-af/mainboard.c @@ -79,6 +79,7 @@ iomux_write8(190, 1); iomux_write8(191, 1); iomux_write8(192, 1); + /* just in case anyone cares */ if (!fch_gpio_state(197)) printk(BIOS_INFO, "BIOS_DEFAULTS jumper is present.\n");
-
Nico Huber (Code Review) -
Paul Menzel (Code Review)