Change in coreboot[master]: mb/google/guybrush: First pass GPIO configuriation for Guybrush - coreboot-gerrit

1 Feb 2021


      Attention is currently required from: Furquan Shaikh, Mathew King.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50091 )
Change subject: mb/google/guybrush: First pass GPIO configuriation for Guybrush
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/50091/comment/31adf6c8_cf39d89c 
PS5, Line 10: 	/* PWR_BTN_L */
...
These correspond to net names on the schematic and are helpful on other boards.
Save for AGPIO/EGPIO, the comments match the macros.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8211dbc3de09a61f264a0e5d44d1eac703b83c9
Gerrit-Change-Number: 50091
Gerrit-PatchSet: 5
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Mathew King mathewk@chromium.org
Gerrit-Comment-Date: Mon, 01 Feb 2021 21:51:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mathew King mathewk@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment