EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Update memory topology ......................................................................
mb/google/deltaur: Update memory topology
Update memory topology for spd info.
BUG=b:151702387
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If314894325d6f222807030a36f8c4cefecfe5bd3 --- M src/mainboard/google/deltaur/variants/deltan/memory.c M src/mainboard/google/deltaur/variants/deltaur/memory.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/40486/1
diff --git a/src/mainboard/google/deltaur/variants/deltan/memory.c b/src/mainboard/google/deltaur/variants/deltan/memory.c index 90fa642..d51ba70 100644 --- a/src/mainboard/google/deltaur/variants/deltan/memory.c +++ b/src/mainboard/google/deltaur/variants/deltan/memory.c @@ -47,6 +47,7 @@ void variant_memory_init(FSP_M_CONFIG *mem_cfg) { const struct spd_info spd_info = { + .topology = SODIMM, .smbus_info[0] = {.addr_dimm0 = 0xa0, .addr_dimm1 = 0 }, .smbus_info[1] = {.addr_dimm0 = 0xa4, diff --git a/src/mainboard/google/deltaur/variants/deltaur/memory.c b/src/mainboard/google/deltaur/variants/deltaur/memory.c index c2df467..c25df39 100644 --- a/src/mainboard/google/deltaur/variants/deltaur/memory.c +++ b/src/mainboard/google/deltaur/variants/deltaur/memory.c @@ -83,6 +83,7 @@ { const struct lpddr4x_cfg *board_cfg = variant_memory_params(); const struct spd_info spd_info = { + .topology = MEMORY_DOWN, .md_spd_loc = SPD_CBFS, .cbfs_index = variant_memory_sku(), };
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Update memory topology ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Update memory topology ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG@7 PS1, Line 7: Update memory topology Please be specific. Something like:
Support SODIMMs
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Varun Joshi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40486
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Update memory topology ......................................................................
mb/google/deltaur: Update memory topology
Update memory topology for spd info. Deltan supports SODIMM and Deltaur supports MEMORYDOWN.
BUG=b:151702387
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If314894325d6f222807030a36f8c4cefecfe5bd3 --- M src/mainboard/google/deltaur/variants/deltan/memory.c M src/mainboard/google/deltaur/variants/deltaur/memory.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/40486/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Update memory topology ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG@7 PS1, Line 7: Update memory topology
Please be specific. Something like: […]
Added in the comment.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Update memory topology ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG@7 PS1, Line 7: Update memory topology
Added in the comment.
I’d prefer it in the summary.
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Varun Joshi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40486
to look at the new patch set (#3).
Change subject: mb/google/deltaur: Add memory topology SODIMM and MEMORYDOWN ......................................................................
mb/google/deltaur: Add memory topology SODIMM and MEMORYDOWN
Update memory topology for spd info. Deltan supports SODIMM and Deltaur supports MEMORYDOWN.
BUG=b:151702387
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If314894325d6f222807030a36f8c4cefecfe5bd3 --- M src/mainboard/google/deltaur/variants/deltan/memory.c M src/mainboard/google/deltaur/variants/deltaur/memory.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/40486/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Add memory topology SODIMM and MEMORYDOWN ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG@7 PS1, Line 7: Update memory topology
I’d prefer it in the summary.
Done 👌
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Add memory topology SODIMM and MEMORYDOWN ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40486/1//COMMIT_MSG@7 PS1, Line 7: Update memory topology
Done 👌
Indeed. ;-)
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40486 )
Change subject: mb/google/deltaur: Add memory topology SODIMM and MEMORYDOWN ......................................................................
mb/google/deltaur: Add memory topology SODIMM and MEMORYDOWN
Update memory topology for spd info. Deltan supports SODIMM and Deltaur supports MEMORYDOWN.
BUG=b:151702387
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: If314894325d6f222807030a36f8c4cefecfe5bd3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/google/deltaur/variants/deltan/memory.c M src/mainboard/google/deltaur/variants/deltaur/memory.c 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/variants/deltan/memory.c b/src/mainboard/google/deltaur/variants/deltan/memory.c index 90fa642..d51ba70 100644 --- a/src/mainboard/google/deltaur/variants/deltan/memory.c +++ b/src/mainboard/google/deltaur/variants/deltan/memory.c @@ -47,6 +47,7 @@ void variant_memory_init(FSP_M_CONFIG *mem_cfg) { const struct spd_info spd_info = { + .topology = SODIMM, .smbus_info[0] = {.addr_dimm0 = 0xa0, .addr_dimm1 = 0 }, .smbus_info[1] = {.addr_dimm0 = 0xa4, diff --git a/src/mainboard/google/deltaur/variants/deltaur/memory.c b/src/mainboard/google/deltaur/variants/deltaur/memory.c index c2df467..c25df39 100644 --- a/src/mainboard/google/deltaur/variants/deltaur/memory.c +++ b/src/mainboard/google/deltaur/variants/deltaur/memory.c @@ -83,6 +83,7 @@ { const struct lpddr4x_cfg *board_cfg = variant_memory_params(); const struct spd_info spd_info = { + .topology = MEMORY_DOWN, .md_spd_loc = SPD_CBFS, .cbfs_index = variant_memory_sku(), };
-
EricR Lai (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)