Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48329 )
Change subject: drivers/crb: Support CapCRBIdleBypass properly ......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/48329/3/src/drivers/crb/tpm.c File src/drivers/crb/tpm.c:
https://review.coreboot.org/c/coreboot/+/48329/3/src/drivers/crb/tpm.c@226 PS3, Line 226: printk(BIOS_ERR, "TPM: Non-IdleBypass TPM left in Ready state, violates PTP spec\n"); KabylakeFspBinPkg seems to violate the specification. This times out several times (startup and measuring payload) and a workaround to put the TPM in idle is needed for TianoCore as well.