[M] Change in coreboot[main]: Choose Correct FW splash screen at runtime

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Julius Werner, Ronak Kanabar, Shelley Chen.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )

Change subject: Choose Correct FW splash screen at runtime
......................................................................

Patch Set 8:

(7 comments)

File src/include/bootsplash.h:

https://review.coreboot.org/c/coreboot/+/79775/comment/599ac1f6_7321750a :
PS7, Line 19: const char *get_bmp_file(void);
> nit: some help text is required to let user know that any user can override this implementation if t […]

Acknowledged

File src/lib/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/b7ca8915_814719c9 :
PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
> > The HAVE_CUSTOM_BMP_LOGO config should be automatically selected by the CHROMEOS_FW_SPLASH_SCREEN  […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/8368c44e_a5b6211a :
PS6, Line 153: HAVE_CUSTOM_BMP_LOGO
> > The HAVE_CUSTOM_BMP_LOGO config should be automatically selected by the CHROMEOS_FW_SPLASH_SCREEN  […]

Acknowledged

File src/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/79775/comment/e1a3ddf8_87de0571 :
PS7, Line 156: ramstage-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += bmp_logo.c
> do we really need this? […]

Acknowledged

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/b115f3f2_1831c0a3 :
PS7, Line 88: Display the ChromeOS splash screen in the firmware.
> nit: Choose this option to let boot firmware to render the OEM splash screen. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/d17d4ea8_c4f0b4c1 :
PS7, Line 91: CB
> nit: should we say "Chromebook" or "ChromeOS" ?

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/31cf783a_ff401ec2 :
PS7, Line 96: CB
> nit: Chromebook ?

Acknowledged