Attention is currently required from: Arthur Heymans, Julius Werner.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 )
Change subject: arch/arm: Use unified assembly syntax
......................................................................
Patch Set 28: Code-Review+2
(1 comment)
Patchset:
PS28:
Does this fix the clang issues with ARM? The commit message could maybe have some information about WHY we're making this change.
Other than that, I think the patch looks good. I'm not the ARM asm expert, but it looks like most of the changes are just ordering.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750
Gerrit-Change-Number: 63058
Gerrit-PatchSet: 28
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 22 Nov 2022 22:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment