Attention is currently required from: Martin Roth, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49943 )
Change subject: This change implements CrashLog for intel TGL.
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/49943/comment/1e6109e8_59dc442b
PS1, Line 271:
trailing whitespace
File src/soc/intel/tigerlake/crashlog_lib.c:
https://review.coreboot.org/c/coreboot/+/49943/comment/4e9c8a46_c5380267
PS1, Line 73: printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n",__func__);
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3763cebcd1178709cc8597710bf062a30901809
Gerrit-Change-Number: 49943
Gerrit-PatchSet: 1
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 26 Jan 2021 18:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment