Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77235?usp=email )
Change subject: mb/google/rex: Update ISH GPIO's configuration ......................................................................
mb/google/rex: Update ISH GPIO's configuration
Configures ISH related GPIO's based on FW_CONFIG obtained from CBI.
BUG=b:280329972,b:283023296 TEST= Set bit 21 of FW_CONFIG with CBI Boot rex board Check that ISH is enabled, loaded, and functional
Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com Change-Id: I778251aadef4499427fc9855adfdd9cade3a3e70 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77235 Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/variants/rex0/fw_config.c 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: Subrata Banik: Looks good to me, approved Bernardo Perez Priego: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/mainboard/google/rex/variants/rex0/fw_config.c b/src/mainboard/google/rex/variants/rex0/fw_config.c index b3958b0..417bc39 100644 --- a/src/mainboard/google/rex/variants/rex0/fw_config.c +++ b/src/mainboard/google/rex/variants/rex0/fw_config.c @@ -85,8 +85,14 @@ PAD_CFG_NF(GPP_B08, NONE, DEEP, NF4), /* GPP_E15 : ISH_GP5A, SOC_ISH_IMU_INT_L */ PAD_CFG_NF(GPP_E15, NONE, DEEP, NF8), + /* GPP_E16 : ISH_GP10, SOC_EC_ISH_NB_MODE */ + PAD_CFG_NF(GPP_E16, NONE, DEEP, NF8), /* GPP_F22 : ISH_GP8A, SOC_ISH_ALS_INT_L */ PAD_CFG_NF(GPP_F22, NONE, DEEP, NF8), + /* GPP_F23 : ISH_GP9A, LID_OPEN_1V8 */ + PAD_CFG_NF(GPP_F23, NONE, DEEP, NF8), + /* GPP_H11 : ISH_GP11A, SOC_ISH_IMU_INT_L */ + PAD_CFG_NF(GPP_H11, NONE, DEEP, NF8), };
static const struct pad_config touchscreen_i2c_int_pads[] = {