Attention is currently required from: Ivy Jian, Nick Vaccaro, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79355?usp=email )
Change subject: mb/google/brox: Fix memory config
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/79355/comment/5523b359_b273f4cb :
PS3, Line 404: const struct pad_config *__weak variant_romstage_gpio_table(size_t *num)
: {
I am afraid the weak override here will be overridden by the table here - https://review.coreboot.org/c/coreboot/+/79295/4/src/mainboard/google/brox/v.... It makes sense to move this config over to the other table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79355?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I17615cda7df10e73e49fb49f736728787ef7625d
Gerrit-Change-Number: 79355
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 30 Nov 2023 23:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment