Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30038 )
Change subject: soc/amd/stoneyridge: Run romstage mainboard code before AGESA ......................................................................
soc/amd/stoneyridge: Run romstage mainboard code before AGESA
This is needed so the next patch can set up GPIOs before AGESA runs.
BUG=b:120436919 TEST=Verified romstage mainboard code runs before AGESA
Change-Id: I76c035e166cd64382b52dff5ae00a6f115cbac9b Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://review.coreboot.org/c/30038 Reviewed-by: Daniel Kurtz djkurtz@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/stoneyridge/romstage.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Daniel Kurtz: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/romstage.c b/src/soc/amd/stoneyridge/romstage.c index ed83e1e..9314488 100644 --- a/src/soc/amd/stoneyridge/romstage.c +++ b/src/soc/amd/stoneyridge/romstage.c @@ -96,11 +96,10 @@ if (IS_ENABLED(CONFIG_SOC_AMD_PSP_SELECTABLE_SMU_FW)) load_smu_fw1();
+ mainboard_romstage_entry(s3_resume);
bsp_agesa_call();
- mainboard_romstage_entry(s3_resume); - if (!s3_resume) { post_code(0x40); do_agesawrapper(agesawrapper_amdinitpost, "amdinitpost");