Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Julius Werner. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot tables: Add PCIe info to coreboot table ......................................................................
Patch Set 9:
(3 comments)
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/8e1635e2_9d286ad1 PS8, Line 91: struct cb_pcie pcie_info;
Copying whole coreboot table entries in here isn't great (I guess we were lazy for the framebuffer b […]
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/b06c29e2_9ea85251 PS8, Line 176: uint64_t atu_base; /* Base address of Address translation unit */
You should really use struct lb_uint64 for all of these to avoid unintentional padding differences b […]
Done, I add a new patch to convert it: https://review.coreboot.org/c/coreboot/+/63494
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/63251/comment/6882619f_3486409b PS8, Line 136: lb_pcie->config_size = pcie->config_size;
Sorry, but something looks off here. […]
Done
-
Jianjun Wang (Code Review)