Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47740 )
Change subject: vendorcode/eltan/secuirty: Add dependency for menu items ......................................................................
vendorcode/eltan/secuirty: Add dependency for menu items
Subitem for VENDORCODE_ELTAN_VBOOT and VENDORCODE_ELTAN_MBOOT are displayed always.
Add dependency and display these items when feature is enabled only.
Tested on Facebook FBG1701.
Change-Id: I51e47efddbcf51d87439bec33b85432da56fa4c6 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/vendorcode/eltan/security/mboot/Kconfig M src/vendorcode/eltan/security/verified_boot/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/47740/1
diff --git a/src/vendorcode/eltan/security/mboot/Kconfig b/src/vendorcode/eltan/security/mboot/Kconfig index 91898fc..540b7b2 100644 --- a/src/vendorcode/eltan/security/mboot/Kconfig +++ b/src/vendorcode/eltan/security/mboot/Kconfig @@ -10,8 +10,11 @@ Enabling MBOOT will use mboot to measure the components of the firmware (stages, payload, etc).
+if VENDORCODE_ELTAN_MBOOT + config VENDORCODE_ELTAN_CRTM_VERSION_STRING string "default CRTM version" default "default CRTM version"
+endif # VENDORCODE_ELTAN_MBOOT endmenu # Measured Boot (mboot) diff --git a/src/vendorcode/eltan/security/verified_boot/Kconfig b/src/vendorcode/eltan/security/verified_boot/Kconfig index b4d1378..7741782 100644 --- a/src/vendorcode/eltan/security/verified_boot/Kconfig +++ b/src/vendorcode/eltan/security/verified_boot/Kconfig @@ -8,6 +8,8 @@ default n select VBOOT_LIB
+if VENDORCODE_ELTAN_VBOOT + config VENDORCODE_ELTAN_VBOOT_SIGNED_MANIFEST bool "Enable Signed Manifest" depends on VENDORCODE_ELTAN_VBOOT @@ -52,4 +54,5 @@ int default 552
+endif # VENDORCODE_ELTAN_VBOOT endmenu # Verified Boot (verified_boot)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47740 )
Change subject: vendorcode/eltan/secuirty: Add dependency for menu items ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/47740/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47740/1//COMMIT_MSG@7 PS1, Line 7: secuirty typo: security
https://review.coreboot.org/c/coreboot/+/47740/1//COMMIT_MSG@10 PS1, Line 10: displayed always nit: `always displayed` sounds more natural
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47740
to look at the new patch set (#2).
Change subject: vendorcode/eltan/security: Add dependency for menu items ......................................................................
vendorcode/eltan/security: Add dependency for menu items
Subitem for VENDORCODE_ELTAN_VBOOT and VENDORCODE_ELTAN_MBOOT are always displayed.
Add dependency and display these items when feature is enabled only.
Tested on Facebook FBG1701.
Change-Id: I51e47efddbcf51d87439bec33b85432da56fa4c6 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/vendorcode/eltan/security/mboot/Kconfig M src/vendorcode/eltan/security/verified_boot/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/47740/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47740 )
Change subject: vendorcode/eltan/security: Add dependency for menu items ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47740/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47740/1//COMMIT_MSG@7 PS1, Line 7: secuirty
typo: security
Done
https://review.coreboot.org/c/coreboot/+/47740/1//COMMIT_MSG@10 PS1, Line 10: displayed always
nit: `always displayed` sounds more natural
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47740 )
Change subject: vendorcode/eltan/security: Add dependency for menu items ......................................................................
vendorcode/eltan/security: Add dependency for menu items
Subitem for VENDORCODE_ELTAN_VBOOT and VENDORCODE_ELTAN_MBOOT are always displayed.
Add dependency and display these items when feature is enabled only.
Tested on Facebook FBG1701.
Change-Id: I51e47efddbcf51d87439bec33b85432da56fa4c6 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47740 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/vendorcode/eltan/security/mboot/Kconfig M src/vendorcode/eltan/security/verified_boot/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/vendorcode/eltan/security/mboot/Kconfig b/src/vendorcode/eltan/security/mboot/Kconfig index 91898fc..540b7b2 100644 --- a/src/vendorcode/eltan/security/mboot/Kconfig +++ b/src/vendorcode/eltan/security/mboot/Kconfig @@ -10,8 +10,11 @@ Enabling MBOOT will use mboot to measure the components of the firmware (stages, payload, etc).
+if VENDORCODE_ELTAN_MBOOT + config VENDORCODE_ELTAN_CRTM_VERSION_STRING string "default CRTM version" default "default CRTM version"
+endif # VENDORCODE_ELTAN_MBOOT endmenu # Measured Boot (mboot) diff --git a/src/vendorcode/eltan/security/verified_boot/Kconfig b/src/vendorcode/eltan/security/verified_boot/Kconfig index b4d1378..7741782 100644 --- a/src/vendorcode/eltan/security/verified_boot/Kconfig +++ b/src/vendorcode/eltan/security/verified_boot/Kconfig @@ -8,6 +8,8 @@ default n select VBOOT_LIB
+if VENDORCODE_ELTAN_VBOOT + config VENDORCODE_ELTAN_VBOOT_SIGNED_MANIFEST bool "Enable Signed Manifest" depends on VENDORCODE_ELTAN_VBOOT @@ -52,4 +54,5 @@ int default 552
+endif # VENDORCODE_ELTAN_VBOOT endmenu # Verified Boot (verified_boot)
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)