Attention is currently required from: Caveh Jalali, Julius Werner, Yu-Ping Wu, Boris Mittelberg.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69762 )
Change subject: vboot: Fix hash digest size, padding and comparison
......................................................................
Patch Set 2:
(1 comment)
File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/69762/comment/53d450d4_3a7b31fc
PS1, Line 344: uint8_t hash_digest[VBOOT_MAX_HASH_SIZE];
Should we do this in vboot_save_hash()? Seems like a weird quirk of the backing store that doesn't r […]
I moved it to vboot_save_hash().
handle_digest_result() also required some rework to allow for vb2_hash to be used in the S3 resume path.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a
Gerrit-Change-Number: 69762
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 13:04:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment