Change in coreboot[master]: cpu/intel/common: rework code previously moved to common cpu code - coreboot-gerrit

21 Oct 2020


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46588 )
Change subject: cpu/intel/common: rework code previously moved to common cpu code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46588/3/src/include/cpu/x86/msr.h 
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/46588/3/src/include/cpu/x86/msr.h@2... 
PS3, Line 24: #define  CPUID_EPP			(1 << 3)
...
Should be named after it's location, e.g. CPUID_6_ECX_SOMETHING. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/46588
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7615fc26625c44931577216ea42f0a733b99e131
Gerrit-Change-Number: 46588
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Oct 2020 12:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment