Attention is currently required from: YH Lin, Tim Wawrzynczak, Sumeet R Pawnikar, Felix Held, Zhuohao Lee.
Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59102 )
Change subject: mb/google/brya/var/gimble: Update thermal table for Gimble
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59102/comment/a095f63a_f830eb39
PS2, Line 11: Critical Policy
`power limits`
Updated.
Commit Message:
https://review.coreboot.org/c/coreboot/+/59102/comment/fd3e82ad_be5d1e23
PS4, Line 9: Disable active policy from baseboard
What's the reason for this ?
I have removed, thanks.
File src/mainboard/google/brya/variants/gimble/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59102/comment/01a34dc6_9c55447f
PS2, Line 51: ## Disable Active Policy from baseboard
: register "policies.active" = "{[0] = {.target=DPTF_NONE}}"
This should not be required, there is no policy defined in the baseoboard. […]
I have removed, thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9899bf49dfaa63ee96532b5b90464d83e02daeee
Gerrit-Change-Number: 59102
Gerrit-PatchSet: 8
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Fri, 12 Nov 2021 04:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment