[XS] Change in coreboot[main]: arch/x86/cpu: Add element id to struct cpu_cache_info - coreboot-gerrit

29 Jan 2025


      Attention is currently required from: Jérémy Compostella, Naresh Solanki.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85639?usp=email )
Change subject: arch/x86/cpu: Add element id to struct cpu_cache_info
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/85639/comment/eae25073_b0d5d06e?usp... :
PS1, Line 280: uint8_t
...
Since its purpose is to uniquely identify a particular cache, I feel cache_id should be fine & pleas […]
maybe 'cache_id'? or is that too redundant?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29002931b559a05756419e0c4ec5c78586d3c3a5
Gerrit-Change-Number: 85639
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Naresh Solanki naresh.solanki@9elements.com
Gerrit-Comment-Date: Wed, 29 Jan 2025 15:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Naresh Solanki naresh.solanki@9elements.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de