Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86553?usp=email )
Change subject: soc/mediatek/mt8196: Disable HWRot's clocks ......................................................................
soc/mediatek/mt8196: Disable HWRot's clocks
HWRot (Hardware Root of trust) is not used, so we disable its clocks to save power. This patch is a subitem of Vcore power consumption improvement. The whole work improves SoC power consumption from 120mW to 90mW in suspend.
BRANCH=rauru BUG=b:377628718 TEST=Bootup OK & Suspend/Resume passed
Signed-off-by: Guangjie Song guangjie.song@mediatek.com Change-Id: I25e607e8e8b2d52608d279e1862f423ca50aab6a Reviewed-on: https://review.coreboot.org/c/coreboot/+/86553 Reviewed-by: Yidi Lin yidilin@google.com Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8196/pll.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/mediatek/mt8196/pll.c b/src/soc/mediatek/mt8196/pll.c index 2007197..91d2fed 100644 --- a/src/soc/mediatek/mt8196/pll.c +++ b/src/soc/mediatek/mt8196/pll.c @@ -1628,14 +1628,14 @@ write32(&mtk_topckgen->clk_cfg[12].set, 0x80800000); write32(&mtk_topckgen->clk_cfg[15].set, 0x8000); write32(&mtk_topckgen->clk_cfg[16].set, 0x800000); - write32(&mtk_topckgen->clk_cfg[18].set, 0x80000000); + write32(&mtk_topckgen->clk_cfg[18].set, 0x80800000); write32(&mtk_topckgen->clk_cfg[19].set, 0x80808000); write32(&mtk_topckgen->clk_cfg[20].set, 0x80808080); write32(&mtk_topckgen->clk_cfg[21].set, 0x80808080); write32(&mtk_topckgen->clk_cfg[22].set, 0x80);
write32(&mtk_vlpsys->vlp_clk_cfg[6].set, 0x80); - write32(&mtk_vlpsys->vlp_clk_cfg[10].set, 0x80800000); + write32(&mtk_vlpsys->vlp_clk_cfg[10].set, 0x80808000); write32(&mtk_vlpsys->vlp_clk_cfg[11].set, 0x80);
write32(&mtk_topckgen2->cksys2_clk_cfg[0].set, 0x80808080);