Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian.
Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68120 )
Change subject: util/amdfwutil: Add some types to both LVL ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/68120/comment/de263f05_4ecd6dc6 PS2, Line 239: PSP_BOTH_AB
If I understand correctly, only ISH tables are expected to be LVL1 on the SoCs with recovery A/B lay […]
I think most things are rather expected in level 2 and not both as level 1 is meant to house sane defaults, but the way we currently build and deploy coreboot for those platforms is already not fully in spec. I think level 2 already has priority over level 1 anyways so considering the entries in level 2 are sane doesn't hurt having them in level 1 as well. We don't have multi-soc support as well so I guess it's fine for now putting these entries in both. Are you aware of a platform which breaks when putting these entries in both?
-
Marvin Drees (Code Review)