Hello Karthikeyan Ramasubramanian,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/33959
to review the following change.
Change subject: drivers/intel/wifi: Make Intel wifi driver arch agnostic ......................................................................
drivers/intel/wifi: Make Intel wifi driver arch agnostic
Mark Intel WiFi driver to depend on PCI and remove the dependency on x86 architecture.
BUG=None BRANCH=None TEST=Compile and Boot to ChromeOS.
Change-Id: I762007d53b43bbc78924ee8efe236d6a7ff4dc57 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/33959/1
diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig index fc8700f..fb60c6f 100644 --- a/src/drivers/intel/wifi/Kconfig +++ b/src/drivers/intel/wifi/Kconfig @@ -1,6 +1,6 @@ config DRIVERS_INTEL_WIFI bool "Support Intel PCI-e WiFi adapters" - depends on ARCH_X86 + depends on PCI default y if PCIEXP_PLUGIN_SUPPORT select DRIVERS_GENERIC_WIFI if HAVE_ACPI_TABLES help
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33959 )
Change subject: drivers/intel/wifi: Make Intel wifi driver arch agnostic ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33959 )
Change subject: drivers/intel/wifi: Make Intel wifi driver arch agnostic ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33959 )
Change subject: drivers/intel/wifi: Make Intel wifi driver arch agnostic ......................................................................
drivers/intel/wifi: Make Intel wifi driver arch agnostic
Mark Intel WiFi driver to depend on PCI and remove the dependency on x86 architecture.
BUG=None BRANCH=None TEST=Compile and Boot to ChromeOS.
Change-Id: I762007d53b43bbc78924ee8efe236d6a7ff4dc57 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33959 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/wifi/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig index fc8700f..fb60c6f 100644 --- a/src/drivers/intel/wifi/Kconfig +++ b/src/drivers/intel/wifi/Kconfig @@ -1,6 +1,6 @@ config DRIVERS_INTEL_WIFI bool "Support Intel PCI-e WiFi adapters" - depends on ARCH_X86 + depends on PCI default y if PCIEXP_PLUGIN_SUPPORT select DRIVERS_GENERIC_WIFI if HAVE_ACPI_TABLES help
-
Furquan Shaikh (Code Review) -
HAOUAS Elyes (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Martin Roth (Code Review)