Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86206?usp=email )
Change subject: mb/starlabs/*: Correct/set UserBd in romstage ......................................................................
mb/starlabs/*: Correct/set UserBd in romstage
Change-Id: Id0c21cc30a0cfc1dccc3f9863e8f3d522afdf31a Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86206 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c M src/mainboard/starlabs/starbook/variants/adl/romstage.c M src/mainboard/starlabs/starbook/variants/adl_n/romstage.c M src/mainboard/starlabs/starbook/variants/mtl/romstage.c M src/mainboard/starlabs/starbook/variants/rpl/romstage.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/romstage.c 6 files changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c index 502411b..530246a 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c @@ -9,6 +9,7 @@ { const struct mb_cfg mem_config = { .type = MEM_TYPE_DDR4, + .UserBd = BOARD_TYPE_ULT_ULX, };
const bool half_populated = true; diff --git a/src/mainboard/starlabs/starbook/variants/adl/romstage.c b/src/mainboard/starlabs/starbook/variants/adl/romstage.c index 17629b4..d31c63e 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/adl/romstage.c @@ -9,6 +9,7 @@ { const struct mb_cfg mem_config = { .type = MEM_TYPE_DDR4, + .UserBd = BOARD_TYPE_MOBILE, };
const bool half_populated = false; diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/romstage.c b/src/mainboard/starlabs/starbook/variants/adl_n/romstage.c index 2130010..2f1d1a2b 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/romstage.c @@ -9,6 +9,7 @@ { const struct mb_cfg mem_config = { .type = MEM_TYPE_DDR4, + .UserBd = BOARD_TYPE_ULT_ULX, };
const bool half_populated = true; diff --git a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c index beb623c..64b7884 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c @@ -9,6 +9,7 @@ { const struct mb_cfg mem_config = { .type = MEM_TYPE_DDR5, + .UserBd = BOARD_TYPE_MOBILE, };
const bool half_populated = false; diff --git a/src/mainboard/starlabs/starbook/variants/rpl/romstage.c b/src/mainboard/starlabs/starbook/variants/rpl/romstage.c index e7e1c6a..a4261e7 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/romstage.c @@ -9,6 +9,7 @@ { const struct mb_cfg mem_config = { .type = MEM_TYPE_DDR4, + .UserBd = BOARD_TYPE_MOBILE, };
const bool half_populated = false; diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/romstage.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/romstage.c index b346241..235a8b4 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/romstage.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/romstage.c @@ -81,7 +81,7 @@ },
.ect = true, - .UserBd = BOARD_TYPE_MOBILE, + .UserBd = BOARD_TYPE_ULT_ULX, .LpDdrDqDqsReTraining = true,
.lp5x_config = {