Change in coreboot[master]: drivers/wifi/generic: Log WiFi wake source to event log

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

5 Oct 2020 5 Oct '20

5:20 a.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

drivers/wifi/generic: Log WiFi wake source to event log

This change adds a call to `pci_dev_log_wake()` to log WiFi wake source to event log just like the Intel WiFi driver does. This is done in preparation to merge the generic and Intel WiFi drivers in follow up changes.

BUG=b:169802515 BRANCH=zork

Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/wifi/generic/generic.c 1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/46032/1

diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index b175f23..059185d 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> +#include <elog.h> #include <sar.h> #include <string.h> #include <wrdd.h> @@ -237,10 +238,16 @@ wifi_generic_fill_ssdt(dev, dev->chip_info); }

+static void wifi_pci_dev_init(struct device *dev) +{ + pci_dev_log_wake(dev, ELOG_WAKE_SOURCE_PME_WIFI, 0); +} + struct device_operations wifi_generic_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, + .init = wifi_pci_dev_init, .ops_pci = &pci_dev_ops_pci, .acpi_name = wifi_generic_acpi_name, .acpi_fill_ssdt = wifi_generic_fill_ssdt_generator,

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Rob Barnes (Code Review)

5 Oct 5 Oct

4:52 p.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 05 Oct 2020 14:52:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

6 Oct 6 Oct

12:48 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 06 Oct 2020 10:48:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

8 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 06 Oct 2020 18:00:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7 Oct 7 Oct

8:08 a.m.

Hello build bot (Jenkins), Duncan Laurie, Michael Niewöhner, Rob Barnes, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46032

to look at the new patch set (#2).

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

drivers/wifi/generic: Log WiFi wake source to event log

This change adds a call to `pci_dev_is_wake_source()` to determine and log WiFi wake source to event log just like the Intel WiFi driver does. This is done in preparation to merge the generic and Intel WiFi drivers in follow-up changes.

BUG=b:169802515 BRANCH=zork

Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/wifi/generic/generic.c 1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/46032/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Rob Barnes (Code Review)

8 Oct 8 Oct

9:36 p.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 08 Oct 2020 19:36:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9 Oct 9 Oct

6:07 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 09 Oct 2020 16:07:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11 Oct 11 Oct

4:13 a.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46032 )

Change subject: drivers/wifi/generic: Log WiFi wake source to event log ......................................................................

drivers/wifi/generic: Log WiFi wake source to event log

BUG=b:169802515 BRANCH=zork

Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46032 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/wifi/generic/generic.c 1 file changed, 8 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index b175f23..2ecaadc 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> +#include <elog.h> #include <sar.h> #include <string.h> #include <wrdd.h> @@ -237,10 +238,17 @@ wifi_generic_fill_ssdt(dev, dev->chip_info); }

+static void wifi_pci_dev_init(struct device *dev) +{ + if (pci_dev_is_wake_source(dev)) + elog_add_event_wake(ELOG_WAKE_SOURCE_PME_WIFI, 0); +} + struct device_operations wifi_generic_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, + .init = wifi_pci_dev_init, .ops_pci = &pci_dev_ops_pci, .acpi_name = wifi_generic_acpi_name, .acpi_fill_ssdt = wifi_generic_fill_ssdt_generator,

-- To view, visit https://review.coreboot.org/c/coreboot/+/46032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20528ae1f72ca633da31e01d777c46fd5f4a337f Gerrit-Change-Number: 46032 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1504

days inactive

1510

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Michael Niewöhner (Code Review)
Rob Barnes (Code Review)
Tim Wawrzynczak (Code Review)