Attention is currently required from: Nick Vaccaro, Paul Menzel, Subrata Banik.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79165?usp=email )
Change subject: mb/google/nissa/var/anraggar: Fix Type-C & DP functions
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79165/comment/5c771e78_7ad6c90d :
PS5, Line 10: relate
relative? or related? not sure.
sorry, it's related. it's mean USB2P_1, USB2N_1 and USB2P_2, USB2N_2 are not exchanged, but TCP0 and TCP1 are exchanged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79165?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dacf06b1e672575a684856acdb10b6c88360b18
Gerrit-Change-Number: 79165
Gerrit-PatchSet: 6
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 29 Nov 2023 06:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment