[L] Change in coreboot[main]: superio/ite: Add special fan vectors, unify it8722f with common - coreboot-gerrit

22 Mar 2024


      Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email )
Change subject: superio/ite: Add special fan vectors, unify it8722f with common
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3: 
Hi Joel, this looks like some very nice coding. However, reviewing it all
at once would take rather long as the patch tackles multiple topics. Would
you mind splitting it up? e.g. one patch to adapt the common ec code, one
to update it8722f and one for cosmetic changes (e.g. s/SUPERIO_DEV/GPIO_DEV/
seems to change nothing, functionality wise).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6
Gerrit-Change-Number: 81310
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Linn jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: MrChromebox mrchromebox@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Joel Linn jl_coreboot@conductive.de
Gerrit-Attention: MrChromebox mrchromebox@gmail.com
Gerrit-Attention: Piotr Król piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 22 Mar 2024 11:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment