Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75563?usp=email )
Change subject: mb/google/kukui: change Juniper/Willow RAM table offset to 0x30
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75563/comment/22e53e11_93336a96 :
PS2, Line 7: Ram
RAM
Done
https://review.coreboot.org/c/coreboot/+/75563/comment/171280e7_4190ffde :
PS2, Line 9: all memory ID
What do you mean by “all memory ID”?
The memory ID in each RAM table.
https://review.coreboot.org/c/coreboot/+/75563/comment/9991946b_c9c548a2 :
PS2, Line 9: for
For
Done
https://review.coreboot.org/c/coreboot/+/75563/comment/c01f3cef_c1018a80 :
PS2, Line 11:
What is the source?
memory 2nd source
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5
Gerrit-Change-Number: 75563
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 01:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment