Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60632 )
Change subject: drivers: Remove unused <acpi/acpi.h> ......................................................................
drivers: Remove unused <acpi/acpi.h>
Found using: diff <(git grep -l '#include <acpi/acpi.h>' -- src/) <(git grep -l 'SLP_EN|SLP_TYP_SHIFT|SLP_TYP|SLP_TYP_S|ACPI_TABLE_CREATOR|OEM_ID|ACPI_DSDT_REV_|acpi_device_sleep_states|ACPI_DEVICE_SLEEP|RSDP_SIG|ASLC|ACPI_NAME_BUFFER_SIZE|COREBOOT_ACPI_ID|acpi_tables|acpi_rsdp|acpi_gen_regaddr|ACPI_ADDRESS_SPACE|ACPI_FFIXEDHW_|ACPI_ACCESS_SIZE_|ACPI_REG_MSR|ACPI_REG_UNSUPPORTED|ACPI_HID_|acpi_table_header|MAX_ACPI_TABLES|acpi_rsdt|acpi_xsdt|acpi_hpet|acpi_mcfg|acpi_tcpa|acpi_tpm2|acpi_mcfg_mmconfig|acpi_hmat|acpi_hmat_mpda|acpi_hmat_sllbi|acpi_hmat_msci|acpi_srat|ACPI_SRAT_STRUCTURE_|acpi_srat_lapic|acpi_srat_mem|acpi_srat_gia|CPI_SRAT_GIA_DEV_HANDLE_|acpi_slit|acpi_madt|acpi_lpit|acpi_lpi_flags|acpi_lpi_desc_type|ACPI_LPI_DESC_TYPE_|acpi_lpi_desc_hdr|ACPI_LPIT_CTR_FREQ_TSC|acpi_lpi_desc_ncst|acpi_vfct_image_hdr|acpi_vfct|acpi_ivrs_info|acpi_ivrs_ivhd|acpi_ivrs|acpi_crat_header|ivhd11_iommu_attr|acpi_ivrs_ivhd_11|dev_scope_type|SCOPE_PCI_|SCOPE_IOAPIC|SCOPE_MSI_HPET|SCOPE_ACPI_NAMESPACE_DEVICE|dev_scope|dmar_type|DMAR_|DRHD_INCLUDE_PCI_ALL|ATC_REQUIRED|DMA_CTRL_PLATFORM_OPT_IN_FLAG|dmar_entry|dmar_rmrr_entry|dmar_atsr_entry|dmar_rhsa_entry|dmar_andd_entry|dmar_satc_entry|acpi_dmar|acpi_apic_types|LOCAL_APIC,|IO_APIC|IRQ_SOURCE_OVERRIDE|NMI_TYPE|LOCAL_APIC_NMI|LAPIC_ADDRESS_|IO_SAPIC|LOCAL_SAPIC|PLATFORM_IRQ_SOURCES|LOCAL_X2APIC|GICC|GICD|GIC_MSI_FRAME|GICR|GIC_ITS|acpi_madt_lapic|acpi_madt_lapic_nmi|ACPI_MADT_LAPIC_NMI_ALL_PROCESSORS|acpi_madt_ioapic|acpi_madt_irqoverride|acpi_madt_lx2apic|acpi_madt_lx2apic_nmi|ACPI_DBG2_PORT_|acpi_dbg2_header|acpi_dbg2_device|acpi_fadt|ACPI_FADT_|PM_UNSPECIFIED|PM_DESKTOP|PM_MOBILE|PM_WORKSTATION|PM_ENTERPRISE_SERVER|PM_SOHO_SERVER|PM_APPLIANCE_PC|PM_PERFORMANCE_SERVER|PM_TABLET|acpi_facs|ACPI_FACS_|acpi_ecdt|acpi_hest|acpi_hest_esd|acpi_hest_hen|acpi_bert|acpi_hest_generic_data|acpi_hest_generic_data_v300|HEST_GENERIC_ENTRY_V300|ACPI_GENERROR_|acpi_generic_error_status|GENERIC_ERR_STS_|acpi_cstate|acpi_sw_pstate|acpi_xpss_sw_pstate|acpi_tstate|acpi_lpi_state_flags|ACPI_LPI_STATE_|acpi_lpi_state|acpi_upc_type|UPC_TYPE_|acpi_ipmi_interface_type|IPMI_INTERFACE_|ACPI_IPMI_|acpi_spmi|ACPI_EINJ_|ACTION_COUNT|BEGIN_INJECT_OP|GET_TRIGGER_ACTION_TABLE|SET_ERROR_TYPE|GET_ERROR_TYPE|END_INJECT_OP|EXECUTE_INJECT_OP|CHECK_BUSY_STATUS|GET_CMD_STATUS|SET_ERROR_TYPE_WITH_ADDRESS|TRIGGER_ERROR|READ_REGISTER|READ_REGISTER_VALUE|WRITE_REGISTER|WRITE_REGISTER_VALUE|NO_OP|acpi_gen_regaddr1|acpi_einj_action_table|acpi_injection_header|acpi_einj_trigger_table|set_error_type|EINJ_PARAM_NUM|acpi_einj_smi|EINJ_DEF_TRIGGER_PORT|FLAG_PRESERVE|FLAG_IGNORE|EINJ_REG_MEMORY|EINJ_REG_IO|acpi_einj|acpi_create_einj|fw_cfg_acpi_tables|preload_acpi_dsdt|write_acpi_tables|acpi_fill_madt|acpi_fill_ivrs_ioapic|acpi_create_ssdt_generator|acpi_write_bert|acpi_create_fadt|acpi_fill_fadt|arch_fill_fadt|soc_fill_fadt|mainboard_fill_fadt|acpi_fill_gnvs|acpi_fill_cnvs|update_ssdt|update_ssdtx|acpi_fill_lpit|acpi_checksum|acpi_add_table|acpi_create_madt_lapic|acpi_create_madt_ioapic|acpi_create_madt_irqoverride|acpi_create_madt_lapic_nmi|acpi_create_madt|acpi_create_madt_lapics|acpi_create_madt_lapic_nmis|acpi_create_madt_lx2apic|acpi_create_srat_lapic|acpi_create_srat_mem|acpi_create_srat_gia_pci|acpi_create_mcfg_mmconfig|acpi_create_srat_lapics|acpi_create_srat|acpi_create_slit|acpi_create_hmat_mpda|acpi_create_hmat|acpi_create_vfct|acpi_create_ipmi|acpi_create_ivrs|acpi_create_crat|acpi_create_hpet|acpi_write_hpet|generate_cpu_entries|acpi_create_mcfg|acpi_create_facs|acpi_create_dbg2|acpi_write_dbg2_pci_uart|acpi_create_dmar|acpi_create_dmar_drhd|acpi_create_dmar_rmrr|acpi_create_dmar_atsr|acpi_create_dmar_rhsa|acpi_create_dmar_andd|acpi_create_dmar_satc|cpi_dmar_|acpi_create_|acpi_write_hest|acpi_soc_get_bert_region|acpi_resume|mainboard_suspend_resume|acpi_find_wakeup_vector|ACPI_S|acpi_sleep_from_pm1|acpi_get_preferred_pm_profile|acpi_get_sleep_type|acpi_get_gpe|permanent_smi_handler|acpi_s3_resume_allowed|acpi_is_wakeup_s3|acpi_align_current|get_acpi_table_revision' -- src/) |grep "<"
Change-Id: Ic890dc7c0ed02891d3144210016cd96f01c344d5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/60632 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth martinroth@google.com --- M src/drivers/i2c/cs42l42/cs42l42.c M src/drivers/i2c/max98373/max98373.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98927/max98927.c M src/drivers/i2c/nau8825/nau8825.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5663/rt5663.c M src/drivers/intel/fsp1_1/ramstage.c M src/drivers/intel/gma/acpi.c M src/drivers/lenovo/wacom.c M src/drivers/tpm/ppi.c M src/drivers/tpm/ppi_stub.c 12 files changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
diff --git a/src/drivers/i2c/cs42l42/cs42l42.c b/src/drivers/i2c/cs42l42/cs42l42.c index a871cfc..dcf83e0 100644 --- a/src/drivers/i2c/cs42l42/cs42l42.c +++ b/src/drivers/i2c/cs42l42/cs42l42.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c index b078674..eb5590d 100644 --- a/src/drivers/i2c/max98373/max98373.c +++ b/src/drivers/i2c/max98373/max98373.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index 664a710..12c8c9d 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c index 642eccf..e80f569f 100644 --- a/src/drivers/i2c/max98927/max98927.c +++ b/src/drivers/i2c/max98927/max98927.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/i2c/nau8825/nau8825.c b/src/drivers/i2c/nau8825/nau8825.c index 01b1f35..0915914 100644 --- a/src/drivers/i2c/nau8825/nau8825.c +++ b/src/drivers/i2c/nau8825/nau8825.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c index 70f1881..6977d95 100644 --- a/src/drivers/i2c/rt1011/rt1011.c +++ b/src/drivers/i2c/rt1011/rt1011.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/i2c/rt5663/rt5663.c b/src/drivers/i2c/rt5663/rt5663.c index 565e3bb..9949566 100644 --- a/src/drivers/i2c/rt5663/rt5663.c +++ b/src/drivers/i2c/rt5663/rt5663.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> diff --git a/src/drivers/intel/fsp1_1/ramstage.c b/src/drivers/intel/fsp1_1/ramstage.c index c5fbd6f..a4b17bd 100644 --- a/src/drivers/intel/fsp1_1/ramstage.c +++ b/src/drivers/intel/fsp1_1/ramstage.c @@ -2,7 +2,6 @@
#include <bootmode.h> #include <bootsplash.h> -#include <acpi/acpi.h> #include <console/console.h> #include <fsp/ramstage.h> #include <fsp/util.h> diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 4a89bb9..b208686 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <string.h> #include "i915.h" diff --git a/src/drivers/lenovo/wacom.c b/src/drivers/lenovo/wacom.c index 0009c14..0d3b433 100644 --- a/src/drivers/lenovo/wacom.c +++ b/src/drivers/lenovo/wacom.c @@ -2,7 +2,6 @@
#include <types.h> #include <console/console.h> -#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <device/device.h> #include <device/pnp.h> diff --git a/src/drivers/tpm/ppi.c b/src/drivers/tpm/ppi.c index 6b02d45..d3c2b1d 100644 --- a/src/drivers/tpm/ppi.c +++ b/src/drivers/tpm/ppi.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <types.h> -#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <acpi/acpi_device.h> #include <cbmem.h> diff --git a/src/drivers/tpm/ppi_stub.c b/src/drivers/tpm/ppi_stub.c index 23236ff..816a3e3 100644 --- a/src/drivers/tpm/ppi_stub.c +++ b/src/drivers/tpm/ppi_stub.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <types.h> -#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <acpi/acpi_device.h>
-
Martin L Roth (Code Review)